glapark commented on code in PR #150:
URL: https://github.com/apache/tez/pull/150#discussion_r1124327517
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/ShuffleScheduler.java:
##########
@@ -1015,51 +1019,63 @@ boolean isShuffleHealthy(InputAttemptIdentifier
srcAttempt) {
final float MIN_REQUIRED_PROGRESS_PERCENT = minReqProgressFraction;
final float MAX_ALLOWED_STALL_TIME_PERCENT = maxStallTimeFraction;
- int doneMaps = numInputs - remainingMaps.get();
+ String errorMsg = null;
Review Comment:
@abstractdog The goal of the patch I submitted was to prevent deadlock, and
it was not about simplifying the logic in check???() methods. At the time of
submitting the patch, I didn't fully understand the details of the logic in
check???() and related methods. Another plan could be to create a new patch for
simplifying the logic here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
