shameersss1 commented on code in PR #274:
URL: https://github.com/apache/tez/pull/274#discussion_r1148785531
##########
tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TezChild.java:
##########
@@ -503,6 +506,32 @@ public static TezChild newTezChild(Configuration conf,
String host, int port, St
hadoopShim);
}
+ private static void eagerInitFileSystemPaths(Configuration conf) {
+ Collection<String> eagerInitPaths = conf.getTrimmedStringCollection(
+ TezConfiguration.TASK_EAGER_INIT_FS_PATHS);
+ if (eagerInitFsPool == null && !eagerInitPaths.isEmpty()) {
+ eagerInitFsPool = Executors.newCachedThreadPool(new
ThreadFactoryBuilder()
+ .setDaemon(true)
+ .setPriority(Thread.MAX_PRIORITY)
+ .setNameFormat("Eager-Init-Fs-Thread-%d")
+ .build());
+ }
+ for (String path : eagerInitPaths) {
+ eagerInitFsPool.execute(new Runnable() {
+ @Override
+ public void run() {
+ try {
+ new Path(path).getFileSystem(conf);
Review Comment:
Wouldn't this be gc'ed eventually? I can see any instances in the code were
we are not explicitly closing the filesystem object. For example :
https://github.com/apache/tez/blob/master/tez-plugins/tez-protobuf-history-plugin/src/main/java/org/apache/tez/dag/history/logging/proto/DatePartitionedLogger.java#L136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
