abstractdog commented on code in PR #301: URL: https://github.com/apache/tez/pull/301#discussion_r1251896895
########## tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java: ########## @@ -895,6 +898,12 @@ protected synchronized void handle(DAGAppMasterEvent event) { } } + private void handleUsedContainersOnDagFinish(DAG dag) { + dag.incrementDagCounter(DAGCounter.TOTAL_CONTAINERS_USED, Review Comment: yeah, idempotency is always better, I'm simply creating a setCounter in DAGImpl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org