abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1546922261
##########
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##########
@@ -79,6 +79,12 @@ public static InputDataInformationEvent
createWithObjectPayload(int srcIndex,
return new InputDataInformationEvent(srcIndex, userPayloadDeserialized,
null);
}
+ public static InputDataInformationEvent createWithSerializedPath(int
srcIndex, String serializedPath) {
+ InputDataInformationEvent event = new InputDataInformationEvent(srcIndex,
null);
+ event.serializedPath = serializedPath;
Review Comment:
this method makes it impossible for users to call constructors in an invalid
way (like: adding payload and serialized path at the same time, which should
not happen), also this has a method name that implies the expected behavior
what constructor are you suggesting that has the same advantages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
