ayushtkn commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2031990575

   > I cannot address [HiddenField], I consider it as noise now
   
   @abstractdog that HiddenField should be fixable, it is telling you have 
localFs already defined above & you are redefining the same variable name in 
the test method, rather than using the class variable
   ```
   diff --git 
a/tez-mapreduce/src/test/java/org/apache/tez/mapreduce/hadoop/TestMRInputHelpers.java
 
b/tez-mapreduce/src/test/java/org/apache/tez/mapreduce/hadoop/TestMRInputHelpers.java
   index c97158d14..a7501e8ae 100644
   --- 
a/tez-mapreduce/src/test/java/org/apache/tez/mapreduce/hadoop/TestMRInputHelpers.java
   +++ 
b/tez-mapreduce/src/test/java/org/apache/tez/mapreduce/hadoop/TestMRInputHelpers.java
   @@ -217,7 +217,6 @@ public class TestMRInputHelpers {
      public void testInputEventSerializedPath() throws IOException {
        MRSplitProto proto = 
MRSplitProto.newBuilder().setSplitBytes(ByteString.copyFrom("splits".getBytes())).build();
    
   -    FileSystem localFs = FileSystem.getLocal(conf);
        Path splitsDir = localFs.resolvePath(localTestRootDir);
    
        Path serializedPath = new Path(splitsDir + Path.SEPARATOR + 
"splitpayload");
   @@ -282,7 +281,6 @@ public class TestMRInputHelpers {
    
      @Test(timeout = 5000)
      public void testInputSplitLocalResourceCreationWithDifferentFS() throws 
Exception {
   -    FileSystem localFs = FileSystem.getLocal(conf);
        Path splitsDir = localFs.resolvePath(localTestRootDir);
    
        DataSourceDescriptor dataSource = 
generateDataSourceDescriptorMapRed(splitsDir);
   
   ```
   
   Just remove that line ``FileSystem localFs = FileSystem.getLocal(conf);`` 
line and it should work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to