okumin commented on code in PR #385:
URL: https://github.com/apache/tez/pull/385#discussion_r1894792001
##########
tez-plugins/tez-aux-services/pom.xml:
##########
@@ -241,15 +242,6 @@
<pattern>io.netty</pattern>
<shadedPattern>org.apache.tez.shaded.$0</shadedPattern>
</relocation>
- <relocation>
- <pattern>javax</pattern>
- <shadedPattern>org.apache.tez.shaded.$0</shadedPattern>
- <excludes>
- <exclude>javax.crypto.*</exclude>
- <exclude>javax.security.**</exclude>
- <exclude>javax.net.**</exclude>
- </excludes>
- </relocation>
Review Comment:
I can see the following jars are currently relocated.
- `org/apache/tez/shaded/javax/annotation/`
- `org/apache/tez/shaded/javax/xml/bind/`
I guess they come from Hadoop. So, "As javax is part of the jdk:" in the
ticket might not be correct. Personally, I don't have any objections to exclude
javax, though
```
+- org.apache.hadoop:hadoop-yarn-api:jar:3.3.6:provided
| +- javax.xml.bind:jaxb-api:jar:2.2.11:compile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
