okumin commented on code in PR #324:
URL: https://github.com/apache/tez/pull/324#discussion_r1894860052
##########
tez-runtime-internals/src/main/java/org/apache/tez/runtime/TezThreadDumpHelper.java:
##########
@@ -70,21 +71,17 @@ private TezThreadDumpHelper(long duration, Configuration
conf) throws IOExceptio
"path: {}", duration, basePath);
}
- public TezThreadDumpHelper() {
Review Comment:
It is originally needed to instantiate
[https://github.com/apache/tez/blob/ca1511998e183c8e10da79bef20463d40a39726a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/TezThreadDumpHelper.java#L182-L194](https://github.com/apache/tez/blob/ca1511998e183c8e10da79bef20463d40a39726a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/TezThreadDumpHelper.java#L182-L194)
with zero arguments.
I think the class is not constructed in a reflective way, or it doesn't
assume it's reflectively operated. I slightly updated the modifiers to make
sure it
https://github.com/apache/tez/pull/324/commits/61d8249fc9051acc1b98dfe6059ea00c4634e6ce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
