Aggarwal-Raghav commented on code in PR #404:
URL: https://github.com/apache/tez/pull/404#discussion_r2023579236
##########
pom.xml:
##########
@@ -1383,6 +1383,40 @@
</dependency>
</dependencies>
</profile>
+ <profile>
+ <id>java17</id>
+ <activation>
+ <jdk>[17,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <argLine>--add-opens java.base/java.lang=ALL-UNNAMED</argLine>
Review Comment:
argLine should also contain the -**_Xmx1024m
-XX:+HeapDumpOnOutOfMemoryError_**, otherwise it will get overwritten. This can
be confirmend by running test in debug mode. Rest of the configuration, evn and
sytem properties are carried forward to java17 profile from the initial maven
surefire plugin
```
mvn test
-Dtest="org.apache.tez.dag.history.recovery.TestRecoveryService#testRecoveryFlushOnSummaryEvent"
-X | grep "argLine"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
