abstractdog commented on code in PR #409: URL: https://github.com/apache/tez/pull/409#discussion_r2063163572
########## Jenkinsfile: ########## @@ -158,6 +157,10 @@ pipeline { YETUS_ARGS+=("--multijdktests=compile") YETUS_ARGS+=("--debug") + # write Yetus report as GitHub comment (YETUS-1102) + YETUS_ARGS+=("--github-write-comment") + YETUS_ARGS+=("--github-use-emoji-vote") Review Comment: hm, I can see that you removed it from the original place does this change have anything to do at all with github-use-emoji-vote? the current change adds 2 extra lines (1 removal + 1 addition) just to have github-use-emoji-vote under the newly added line, is it for a reason? why don't simply add: ``` # write Yetus report as GitHub comment (YETUS-1102) YETUS_ARGS+=("--github-write-comment") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org