[
https://issues.apache.org/jira/browse/TEZ-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor updated TEZ-4660:
------------------------------
Description:
https://github.com/apache/tez/pull/440
there is a chance that this will be a yetus ticket, but for now, I'm tracking
this in tez
in the above PR, I created two commits, a bad one, and a revert, resulting in
no effective code change, still, yetus reported the problem in the original
commit:
{code}
src/main/java/org/apache/tez/dag/api/BadClassWithoutAsfLicence.java:1:Missing
Apache License
{code}
in another PR, where I discovered this behavior, this happened to spotcheck,
asflicence, checkstyle, etc. causing a lot of reported problems, that are no
longer part of the PR
unfortunately, there are plenty of cases when we don't want to squash commits
for a reason
corresponding files in tez repo:
https://github.com/apache/tez/blob/master/Jenkinsfile
https://github.com/apache/tez/blob/master/build-tools/test-patch.sh
as far as I can remember, test-patch.sh is from yetus to customize our
precommit workflow, maybe the bug is hidden there (in tez)
was:
https://github.com/apache/tez/pull/440
there is a chance that this will be a yetus ticket, but for now, I'm tracking
this in tez
in the above PR, I created two commits, a bad one, and a revert, resulting in
no effective code change, still, yetus reported the problem in the original
commit:
{code}
src/main/java/org/apache/tez/dag/api/BadClassWithoutAsfLicence.java:1:Missing
Apache License
{code}
in another PR, where I discovered this behavior, this happened to spotcheck,
asflicence, checkstyle, etc. causing a lot of reported problems, that are no
longer part of the PR
unfortunately, there are plenty of cases when we don't want to squash commits
for a reason
corresponding files in tez repo:
https://github.com/apache/tez/blob/master/Jenkinsfile
https://github.com/apache/tez/blob/master/build-tools/test-patch.sh
as far as I can remember, test-patch.sh is from yetus to customize our
precommit workflow, maybe the bug is hidden there somewhere
> Yetus doesn't run on the tip commit effectively
> -----------------------------------------------
>
> Key: TEZ-4660
> URL: https://issues.apache.org/jira/browse/TEZ-4660
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: László Bodor
> Priority: Major
>
> https://github.com/apache/tez/pull/440
> there is a chance that this will be a yetus ticket, but for now, I'm tracking
> this in tez
> in the above PR, I created two commits, a bad one, and a revert, resulting in
> no effective code change, still, yetus reported the problem in the original
> commit:
> {code}
> src/main/java/org/apache/tez/dag/api/BadClassWithoutAsfLicence.java:1:Missing
> Apache License
> {code}
> in another PR, where I discovered this behavior, this happened to spotcheck,
> asflicence, checkstyle, etc. causing a lot of reported problems, that are no
> longer part of the PR
> unfortunately, there are plenty of cases when we don't want to squash commits
> for a reason
> corresponding files in tez repo:
> https://github.com/apache/tez/blob/master/Jenkinsfile
> https://github.com/apache/tez/blob/master/build-tools/test-patch.sh
> as far as I can remember, test-patch.sh is from yetus to customize our
> precommit workflow, maybe the bug is hidden there (in tez)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
