abstractdog commented on code in PR #427:
URL: https://github.com/apache/tez/pull/427#discussion_r2565154649
##########
tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java:
##########
@@ -1612,19 +1613,14 @@ DAGState initializeDAG() {
addVertex(v);
}
- // check task resources, only check it in non-local mode
if (!appContext.isLocal()) {
- for (Vertex v : vertexMap.values()) {
- // TODO TEZ-2003 (post) TEZ-2624 Ideally, this should be per source.
- if
(v.getTaskResource().compareTo(appContext.getClusterInfo().getMaxContainerCapability())
> 0) {
- String msg = "Vertex's TaskResource is beyond the cluster container
capability," +
- "Vertex=" + v.getLogIdentifier() +", Requested TaskResource=" +
v.getTaskResource()
- + ", Cluster MaxContainerCapability=" +
appContext.getClusterInfo().getMaxContainerCapability();
- LOG.error(msg);
- addDiagnostic(msg);
- finished(DAGState.FAILED);
- return DAGState.FAILED;
- }
+ try {
+ appContext.getAmExtensions().checkTaskResources(vertexMap,
appContext.getClusterInfo());
+ } catch (TaskResourceException e) {
Review Comment:
ack, also the specialized TaskResourceException exception can be removed, it
has no added value at the moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
