abstractdog commented on code in PR #427:
URL: https://github.com/apache/tez/pull/427#discussion_r2671729361
##########
tez-api/src/main/java/org/apache/tez/client/registry/AMRecord.java:
##########
@@ -125,9 +154,11 @@ public boolean equals(Object other) {
}
if (other instanceof AMRecord otherRecord) {
return appId.equals(otherRecord.appId)
- && host.equals(otherRecord.host)
+ && hostName.equals(otherRecord.hostName)
Review Comment:
this is initialized from DAGAppMaster:
https://github.com/apache/tez/pull/427/files#diff-54ba4a2af15261379079ed5a9c1f9eea52da7bdd3f1109fe7b96d4abf07f6173R677-R678
```
AMRecord amRecord = amRegistry.createAmRecord(appId,
rpcServerAddress.getHostName(),
rpcServerAddress.getAddress().getHostAddress(),
rpcServerAddress.getPort(), computeName);
```
hostName is not supposed to be null, so if it's null, it's already a fatal
issue, which is revealed by NPE, I don't think we make this better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
