Aggarwal-Raghav commented on code in PR #458:
URL: https://github.com/apache/tez/pull/458#discussion_r2836336896
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -2429,7 +2430,10 @@ public static void main(String[] args) {
Objects.requireNonNull(appSubmitTimeStr,
ApplicationConstants.APP_SUBMIT_TIME_ENV + " is null");
- Configuration conf = new Configuration();
+ Configuration conf =
+
STANDALONE_ZOOKEEPER.name().equals(System.getenv(TezConstants.TEZ_FRAMEWORK_MODE))
+ ? new TezConfiguration()
+ : new Configuration();
Review Comment:
Thanks, @abstractdog, for pointing out
[TEZ-4014](https://issues.apache.org/jira/browse/TEZ-4014).It works well,
provided we pass `TEZ_FRAMEWORK_MODE=STANDALONE_ZOOKEEPER` as an environment
variable (using the `--env-file` or `-e` flag in the `docker run` command) and
ensure `tez-site.xml` is in the classpath.
Without this environment variable, it defaults back to YARN mode. I might
have missed passing the `-e` flag initially while working on `TEZ-4682` stared
using with `new TezConfiguration()` as in current TEZ-4682 PR
https://github.com/apache/tez/commit/551075bc420baab15ce3f3df1f4445b4c334cab8
and never checked back :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
