abstractdog commented on PR #456: URL: https://github.com/apache/tez/pull/456#issuecomment-3959715583
> Thanks for the thorough review @abstractdog . I'll address the review comments shortly, you can continue the review in the meantime. I hope you are able to build the image and start tez am standalone process 😅 > > I still believe we can get rid of hadoop tarball dependency completely as the hadoop dependent required jars are already part of tez tarball. It might unnecessary increase docker image size. > > Also please suggest should I use eclipse-temurin:21.0.3_9-**jre**-ubi9-minimal or **jdk**, in case we want to take jstack or other java debugging tools, jkd image is required. 1. I believe as long as a simple DAG can run without adding hadoop jars (other than what's already insided tez.tar.gz), it fine to get rid of them: we cannot test it now, but we can still check if the AM starts correctly, and if so, we're good 2. regarding debugging tools: I would add them in the first round, and we can still optimize later: these images are not for production in the first round, so I would rather have a slightly bigger image with debugging tools than having a small image that's harder to use while investigating something -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
