Aggarwal-Raghav commented on code in PR #465:
URL: https://github.com/apache/tez/pull/465#discussion_r2941824290
##########
tez-dag/pom.xml:
##########
@@ -209,9 +209,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
- <argLine>${test.jvm.args}</argLine>
- <environmentVariables>
- <LOG_DIRS>${test.log.dir}</LOG_DIRS>
Review Comment:
There is no need to explicit surefire plugins in child pom. Moved LOG_DIRS
to parent pom and used `<environmentVariables combine.children="append">` to
ensure the argline and other env variables defined in parent pom under surefire
plugins are available to child pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]