abstractdog commented on code in PR #464:
URL: https://github.com/apache/tez/pull/464#discussion_r2954661804
##########
tez-mapreduce/src/main/java/org/apache/tez/mapreduce/client/YARNRunner.java:
##########
@@ -640,6 +643,7 @@ public JobStatus submitJob(JobID jobId, String
jobSubmitDir, Credentials ts)
tezClient = new MRTezClient("MapReduce", dagAMConf, false,
jobLocalResources, ts);
tezClient.start();
dagClient = new MRDAGClient(tezClient.submitDAGApplication(appId, dag));
+ dagClientMap.put(jobId, dagClient);
Review Comment:
I was worried that items are not evicted from dagClientMap, but something
similar is happening in case of ClientCache too:
https://github.com/apache/tez/blob/9725e38fbd67ef659a5ba6bbfa0ccf35f9f764b0/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/client/ClientCache.java#L40
maybe we can take care of this in a followup ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
