abstractdog commented on PR #481: URL: https://github.com/apache/tez/pull/481#issuecomment-4363091296
> > What is the motivation behind this? > > This has been discussed in hadoop as well & blocked every time: [apache/hadoop#6937 (comment)](https://github.com/apache/hadoop/pull/6937#issuecomment-2221002917) > > The ticket mentioned in the Jira > > > This is the same as [HADOOP-16611](https://issues.apache.org/jira/browse/HADOOP-16611) but for Tez > > > > > > This is also resolved as `Not a Problem` The PR linked was also abandoned: [apache/hadoop#1523 (comment)](https://github.com/apache/hadoop/pull/1523#issuecomment-535461886) > > @ayushtkn , for changes in README, pom, Jenkinsfile or Dockerfile, it doesn't contains UT and it give `-1` as overall yetus outcome. One can argue for Java changes if no UT is there then `-1` is correct behaviour but I don't see any file extension based decision making in yetus. > > In `build-tools/test-patch.sh` checkTests(), the behaviour is if "documentation" keyword is present in PR title then it will not give -1 (I've not tested this behaviour) > > ``` > testReferences=`$GREP -c -i -e '^+++.*/test' $PATCH_DIR/patch` > echo "There appear to be $testReferences test files referenced in the patch." > if [[ $testReferences == 0 ]] ; then > if [[ $JENKINS == "true" ]] ; then > patchIsDoc=`$GREP -c -i 'title="documentation' $PATCH_DIR/jira` > if [[ $patchIsDoc != 0 ]] ; then > echo "The patch appears to be a documentation patch that doesn't require tests." > JIRA_COMMENT="$JIRA_COMMENT > > {color:green}+0 tests included{color}. The patch appears to be a documentation patch that doesn't require tests." > return 0 > fi > fi > JIRA_COMMENT="$JIRA_COMMENT > ``` > > **All in all its a PMC's decision what behaviour is more favourable for the project in long run** . Please discuss among yourselves and let me know if I need to close this PR. no strong opinions about this, ultimately it's about the confetti_ball vs. broken_heart icon on top of the yetus report, but it doesn't break the pipeline, and lets the reviewer decide whether the patch is correct and merge, I'm fine with keeping as is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
