maheshrajus commented on code in PR #474:
URL: https://github.com/apache/tez/pull/474#discussion_r3258541501
##########
tez-plugins/tez-history-parser/pom.xml:
##########
@@ -145,8 +145,19 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-json</artifactId>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
Review Comment:
After jersey 2.x upgrade some tests are failed and while fixing the tests we
added these dependency.
This module still primarily uses JUnit 4 style tests, but after the upgrade
the tests required JUnit 5 platform compatibility dependencies
(junit-jupiter-api and junit-vintage-engine) to execute correctly.
junit-vintage-engine is needed to run the existing JUnit 4 tests on the
JUnit 5 platform/runtime. Some other modules only required junit-jupiter-api,
likely due to differences in their existing test dependency setup.
I limited the changes to the minimum required(junit-jupiter-api) for the
affected modules instead of introducing both.
We can raise followup ticket for this to check and fix separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
