abstractdog commented on code in PR #512:
URL: https://github.com/apache/tez/pull/512#discussion_r3473034525
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -528,6 +529,12 @@ protected void serviceInit(final Configuration conf)
throws Exception {
jobTokenSecretManager.addTokenForJob(
appAttemptID.getApplicationId().toString(), sessionToken);
+ // Create a JobTokenSecretManager initialized with the session token's
password
+ // for shuffle delete requests. The shuffle handler verifies requests
using the
+ // token password, so the MAC must be initialized with it (as tasks do).
+ shuffleJobTokenSecretManager = new JobTokenSecretManager(
Review Comment:
that's right, thanks for clarifying, I tend to forget SecretManager internals
so the code comment indeed explains the situation well: client side uses the
instance method, so we must initialize the instance MAC with the sessionToken,
which is used from the map on the server/shufflehandler side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
