abstractdog commented on code in PR #524:
URL: https://github.com/apache/tez/pull/524#discussion_r3629866227
##########
tez-api/src/main/java/org/apache/tez/common/security/ACLManager.java:
##########
@@ -76,10 +76,11 @@ public ACLManager(String amUser, Configuration conf) {
public ACLManager(ACLManager amACLManager, String dagUser, ACLInfo aclInfo) {
this.amUser = amACLManager.amUser;
this.dagUser = dagUser;
- this.users = amACLManager.users;
- this.groups = amACLManager.groups;
+ // Copy the AM-level maps so per-DAG entries stay scoped to this DAG.
+ this.users = new HashMap<>(amACLManager.users);
+ this.groups = new HashMap<>(amACLManager.groups);
Review Comment:
thanks @ayushtkn, that's absolutely valid, fixed in
https://github.com/apache/tez/pull/524/changes/6142f4bc6986ab39dad1d95a21df5f9af7ae5e79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
