[
https://issues.apache.org/jira/browse/TEZ-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor updated TEZ-4744:
------------------------------
Description:
TEZ-4736 fixes a flakiness that's related to session ending, I'm wondering if
we can introduce a unified helper method that can wait and assert a certain
state, making unit tests more robust
{code}
grep -iRH "tezSession.waitTillReady" --include="*.java"
tez-tests/src/test/java/org/apache/tez/test/TestFaultTolerance.java:
tezSession.waitTillReady();
tez-tests/src/test/java/org/apache/tez/test/TestFaultTolerance.java:
tezSession.waitTillReady();
tez-tests/src/test/java/org/apache/tez/test/TestAMRecoveryAggregationBroadcast.java:
tezSession.waitTillReady();
tez-tests/src/test/java/org/apache/tez/test/FaultToleranceTestRunner.java:
tezSession.waitTillReady();
tez-tests/src/test/java/org/apache/tez/test/TestAMRecovery.java:
tezSession.waitTillReady();
tez-tests/src/test/java/org/apache/tez/test/TestDAGRecovery.java:
tezSession.waitTillReady();
tez-tests/src/main/java/org/apache/tez/mapreduce/examples/UnionExample.java:
tezSession.waitTillReady();
tez-tests/src/main/java/org/apache/tez/mapreduce/examples/BroadcastAndOneToOneExample.java:
tezSession.waitTillReady();
tez-tests/src/main/java/org/apache/tez/mapreduce/examples/TestOrderedWordCount.java:
tezSession.waitTillReady();
tez-tools/analyzers/job-analyzer/src/test/java/org/apache/tez/analyzer/TestAnalyzer.java:
tezSession.waitTillReady();
{code}
> Unify tezSession.waitTillReady usage in unit tests
> --------------------------------------------------
>
> Key: TEZ-4744
> URL: https://issues.apache.org/jira/browse/TEZ-4744
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: László Bodor
> Priority: Major
>
>
> TEZ-4736 fixes a flakiness that's related to session ending, I'm wondering if
> we can introduce a unified helper method that can wait and assert a certain
> state, making unit tests more robust
>
> {code}
> grep -iRH "tezSession.waitTillReady" --include="*.java"
> tez-tests/src/test/java/org/apache/tez/test/TestFaultTolerance.java:
> tezSession.waitTillReady();
> tez-tests/src/test/java/org/apache/tez/test/TestFaultTolerance.java:
> tezSession.waitTillReady();
> tez-tests/src/test/java/org/apache/tez/test/TestAMRecoveryAggregationBroadcast.java:
> tezSession.waitTillReady();
> tez-tests/src/test/java/org/apache/tez/test/FaultToleranceTestRunner.java:
> tezSession.waitTillReady();
> tez-tests/src/test/java/org/apache/tez/test/TestAMRecovery.java:
> tezSession.waitTillReady();
> tez-tests/src/test/java/org/apache/tez/test/TestDAGRecovery.java:
> tezSession.waitTillReady();
> tez-tests/src/main/java/org/apache/tez/mapreduce/examples/UnionExample.java:
> tezSession.waitTillReady();
> tez-tests/src/main/java/org/apache/tez/mapreduce/examples/BroadcastAndOneToOneExample.java:
> tezSession.waitTillReady();
> tez-tests/src/main/java/org/apache/tez/mapreduce/examples/TestOrderedWordCount.java:
> tezSession.waitTillReady();
> tez-tools/analyzers/job-analyzer/src/test/java/org/apache/tez/analyzer/TestAnalyzer.java:
> tezSession.waitTillReady();
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)