Aggarwal-Raghav commented on code in PR #529:
URL: https://github.com/apache/tez/pull/529#discussion_r3691779066
##########
tez-api/src/test/java/org/apache/tez/client/TestTezClient.java:
##########
@@ -382,7 +382,7 @@ public void testGetClient() throws Exception {
client2.stop();
verify(client2.sessionAmProxy, times(1)).shutdownSession(any(),
any());
- verify(client2.mockYarnClient, times(1)).stop();
+ verify(client2.mockYarnClient, times(1)).close();
Review Comment:
Mockito4 couldn't mock final methods and `yarnClient.close()` was final so
it was checking for `stop()` in AbstractService.java
```
@Override
public final void close() throws IOException {
stop();
}
```
But in Mockito 5 it can mock final method so it will test for `close()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
