Aggarwal-Raghav commented on code in PR #532:
URL: https://github.com/apache/tez/pull/532#discussion_r3761338588
##########
tez-api/findbugs-exclude.xml:
##########
@@ -142,4 +142,11 @@
<Method name="get" params="java.lang.Class,
org.apache.hadoop.conf.Configuration, java.lang.Class"
returns="org.apache.tez.frameworkplugins.FrameworkService" />
<Bug pattern="REFLC_REFLECTION_MAY_INCREASE_ACCESSIBILITY_OF_CLASS" />
</Match>
+
+ <!-- TEZ-4749 -->
+ <Match>
+ <Class name="org.apache.tez.client.registry.zookeeper.ZkConfig" />
+ <Method name="isSslEnabled" />
Review Comment:
For NULL check , updating spotbugs confis seems overkill, can't we use java
`OPTIONAL` ?
##########
tez-api/findbugs-exclude.xml:
##########
@@ -142,4 +142,11 @@
<Method name="get" params="java.lang.Class,
org.apache.hadoop.conf.Configuration, java.lang.Class"
returns="org.apache.tez.frameworkplugins.FrameworkService" />
<Bug pattern="REFLC_REFLECTION_MAY_INCREASE_ACCESSIBILITY_OF_CLASS" />
</Match>
+
+ <!-- TEZ-4749 -->
+ <Match>
+ <Class name="org.apache.tez.client.registry.zookeeper.ZkConfig" />
+ <Method name="isSslEnabled" />
Review Comment:
For NULL check , updating spotbugs configs seems overkill, can't we use java
`OPTIONAL` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
