Aggarwal-Raghav commented on PR #534:
URL: https://github.com/apache/tez/pull/534#issuecomment-5399808711
Before (Using idiv):
```
f10 | 88 0x0000000111c23eb0: ;*idiv {reexecute=0 rethrow=0 return_oop=0}
37 02f9
; -
org.apache.tez.runtime.library.common.writers.UnorderedPartitionedKVWriter::write@228
(line 459)
0x0000000111e7581c: ; {runtime_call SafepointBlob}
0x0000000111c23eb0: 0a7d 0213 | ea9f 00b9 | 0228 40b9 | 4200 00b4
0x0000000111e7581c
: 39d4 d215
0x0000000111c23ec0: ;*getfield partitionPositions {reexecute=0 rethrow=0
return_oop=0}
Result
"org.apache.tez.runtime.library.common.writers.PerfTestKVWriter.testWriteHotPath":
34.908 ±(99.9%) 15.536 ns/op [Average]
(min, avg, max) = (34.070, 34.908, 35.772), stdev = 0.852
CI (99.9%): [19.372, 50.444] (assumes normal distribution)
Benchmark Mode Cnt Score Error Units
PerfTestKVWriter.testWriteHotPath avgt 3 34.908 ± 15.536 ns/op
```
After (Using Integer Unsigned SHift Right i.e. iushr):
```
{0x000000b000154be8} 0x000000011988980c: ;*iushr {reexecute=0 rethrow=0
return_oop=0}
'guard_LI_I' ; -
org.apache.tez.runtime.library.common.writers.UnorderedPartitionedKVWriter::write@223
(line 466)
0x000000011988980c: 807e 0253 | 5f03 0a6b | 4225 0054
'
(Ljava/lang/invoke/VarHandle;Ljava/lang/Object;ILjava/lang/invoke/VarHandle$AccessDescriptor;)I'
0x0000000119889818: ;*isub {reexecute=0 rethrow=0 return_oop=0}
in 'java/lang/invoke/VarHandleGuards ; -
org.apache.tez.runtime.library.common.writers.UnorderedPartitionedKVWriter::write@242
(line 468)
'
Result
"org.apache.tez.runtime.library.common.writers.PerfTestKVWriter.testWriteHotPath":
34.409 ±(99.9%) 2.906 ns/op [Average]
(min, avg, max) = (34.269, 34.409, 34.582), stdev = 0.159
CI (99.9%): [31.503, 37.315] (assumes normal distribution)
Benchmark Mode Cnt Score Error Units
PerfTestKVWriter.testWriteHotPath avgt 3 34.409 ± 2.906 ns/op
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
