[
https://issues.apache.org/jira/browse/TEZ-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875303#comment-13875303
]
Hitesh Shah commented on TEZ-722:
---------------------------------
Comment on the patch:
[~jeagles] Do you think it makes sense to do something such as the following as
compared to the current patch?
{code}
public RawComparator<?> getCombinerKeyGroupingComparator() {
if (conf.get("mapreduce.job.combiner.group.comparator.class") {
// return instance of the configured class
} // else
return getSortComparator();
}
{code}
Also, I believe changes will probably be required in
org.apache.tez.mapreduce.combine.MRCombiner itself to make use of the correct
comparator.
> Tez trunk doesn't compile against latest branch-2
> -------------------------------------------------
>
> Key: TEZ-722
> URL: https://issues.apache.org/jira/browse/TEZ-722
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Raja Aluri
> Assignee: Jonathan Eagles
> Attachments: TEZ-722.patch, TEZ-722.patch
>
>
> Tez trunk doesn't compile against latest branch-2 (Which is going to be 2.4.0)
> {code}
> INFO] Final Memory: 32M/3833M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile)
> on project tez-mapreduce: Compilation failure
> [ERROR]
> /grid/0/workspace/APACHE-BIGTOP-HDP_RPM_REPO-baikal-GA/label/centos6-builds/bigtop-0.5/build/tez/rpm/BUILD/tez-0.4.0.9.9.9.9/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapreduce/JobContextImpl.java:[57,8]
> org.apache.tez.mapreduce.hadoop.mapreduce.JobContextImpl is not abstract and
> does not override abstract method getCombinerKeyGroupingComparator() in
> org.apache.hadoop.mapreduce.JobContext
> [ERROR] -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
> (default-compile) on project tez-mapreduce: Compilation failure
> /grid/0/workspace/APACHE-BIGTOP-HDP_RPM_REPO-baikal-GA/label/centos6-builds/bigtop-0.5/build/tez/rpm/BUILD/tez-0.4.0.9.9.9.9/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapreduce/JobContextImpl.java:[57,8]
> org.apache.tez.mapreduce.hadoop.mapreduce.JobContextImpl is not abstract and
> does not override abstract method getCombinerKeyGroupingComparator() in
> org.apache.hadoop.mapreduce.JobContext
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
