[
https://issues.apache.org/jira/browse/TEZ-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878910#comment-13878910
]
Bikas Saha commented on TEZ-724:
--------------------------------
Doesnt the first the stmt cover the second stmt if we dont check for the CUSTOM
property.
{code}if (edge.getDataMovementType() == PlanEdgeDataMovementType.CUSTOM) {
+ return new EdgeProperty(
+ (edge.hasEdgeManager() ?
convertEdgeManagerDescriptorFromDAGPlan(edge.getEdgeManager()) : null),
+ convertFromDAGPlan(edge.getDataSourceType()),
+ convertFromDAGPlan(edge.getSchedulingType()),
+ convertOutputDescriptorFromDAGPlan(edge.getEdgeSource()),
+ convertInputDescriptorFromDAGPlan(edge.getEdgeDestination())
+ );
+ } else {
+ return new EdgeProperty(
+ convertFromDAGPlan(edge.getDataMovementType()),
+ convertFromDAGPlan(edge.getDataSourceType()),
+ convertFromDAGPlan(edge.getSchedulingType()),
+ convertOutputDescriptorFromDAGPlan(edge.getEdgeSource()),
+ convertInputDescriptorFromDAGPlan(edge.getEdgeDestination())
+ );
+ }{code}
lgtm.
Side note: We should probably move to a factory.newInstance model for all our
API objects.
> DAG API to specify and add a custom data movement edge
> ------------------------------------------------------
>
> Key: TEZ-724
> URL: https://issues.apache.org/jira/browse/TEZ-724
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Siddharth Seth
> Attachments: TEZ-724.2.txt, TEZ-724.3.txt, TEZ-724.4.txt,
> TEZ-724.wip.1.txt
>
>
> We will need a CUSTOM data movement type enum. Also, optionally, a user
> should be able to specify a custom edge manager to route using custom logic.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
