[ 
https://issues.apache.org/jira/browse/TEZ-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946011#comment-13946011
 ] 

Siddharth Seth commented on TEZ-879:
------------------------------------

bq. might be good to use a static Pattern.compile()
Done

bq. identation is off ?
Fixed

bq. Seems wrong to do this. Why not throw an error and fail the task?
The translation from bytes to MB can call this. Have changed functionality to 
round up to 1MB if > 0 but < 1MB, and throw an exception if btyes is lower than 
1MB.

bq. looks like we need to run findbugs on the codebase .
Good point. I had missed fixing the MergeManager in the patch.



> Investigate synchronization in Inputs/Outputs .initialize() etc
> ---------------------------------------------------------------
>
>                 Key: TEZ-879
>                 URL: https://issues.apache.org/jira/browse/TEZ-879
>             Project: Apache Tez
>          Issue Type: Task
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-879.1.txt
>
>
> Initialization, start etc happens in separate threads. Some synchronization - 
> primarily for visibility - may be required.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to