[ https://issues.apache.org/jira/browse/TEZ-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950361#comment-13950361 ]
Mohammad Kamrul Islam commented on TEZ-988: ------------------------------------------- Some comments: > DEFAULT_TEZ_RUNTIME_SHUFFLE_KEEP_ALIVE_MAX_CONNECTIONS = 20; Why the default is 20? why is it not to current default of 5? >int ret = 0; No used in any place. Please remove it. > url.append("&keepAlive=").append(keepAlive); If keepAlive is set to 'true' in mapped-site.xml and there is no config to override this in Tez, what will be the value of keep alive. Will this patch make it to 'false'? can you pls double check the logic? > http.maxConnections needs to be configurable in Tez Fetcher & read from > errorstream to make the connection reusable > ------------------------------------------------------------------------------------------------------------------- > > Key: TEZ-988 > URL: https://issues.apache.org/jira/browse/TEZ-988 > Project: Apache Tez > Issue Type: Bug > Affects Versions: 0.4.0 > Reporter: Rajesh Balamohan > Assignee: Rajesh Balamohan > Attachments: TEZ-988-v1.patch > > > 1. Currently http.maxConnections is set to 5 (default). Make this > configurable in Fetcher.java. This will help in running larger queries > 2. ErrorStream has to be read completely in order to make the connection > reusable (when keepAlive is enabled). Currently, we do not read error stream. -- This message was sent by Atlassian JIRA (v6.2#6252)