[
https://issues.apache.org/jira/browse/TEZ-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971843#comment-13971843
]
Siddharth Seth commented on TEZ-695:
------------------------------------
This potentially introduces races in terms of context and numInput visibility.
initialize() and start() are almost always called in separate threads.
What's the exepcted usage after this, should AbstractLogicalInput be extended,
or should LogicalInput be implemented. We should just remove LogicalInput in
favour of AbstractLogicalInput being the only option available (incompatible
change though).
> Create Abstract class for Input/Processor/Output
> ------------------------------------------------
>
> Key: TEZ-695
> URL: https://issues.apache.org/jira/browse/TEZ-695
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Mohammad Kamrul Islam
> Fix For: 0.5.0
>
> Attachments: TEZ-695.1.patch, TEZ-695.2.patch, TEZ-695.3.patch,
> TEZ-695.4.patch, TEZ-695.5.patch, TEZ-695.6.patch
>
>
> Currently, the context is passed to IPO objects in the initialize method and
> its their burden to save a copy for future use. Having an abstract class for
> them would allow common things like this to be done in the abstract class and
> reduce the burden on the IPO developer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
