[
https://issues.apache.org/jira/browse/TEZ-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003967#comment-14003967
]
Siddharth Seth commented on TEZ-1089:
-------------------------------------
Mostly looks good,
Could you please change the variable name in the .proto file as well.
Also, the test you had in the first patch is missing in the second.
In the unit test, should
{code}assertEquals(numPartitions,
(cdme.getSourceIndexStart()+cdme.getCount()));{code}
be
{code}
assertEquals(numPartitions, (cdme.getCount()));
{code}
Similarly for
{code}assertEquals(numOutputs,
(cdme.getSourceIndexStart()+cdme.getCount()));{code}
> CompositeDataMovementEvent srcIndexEnd is not an index
> ------------------------------------------------------
>
> Key: TEZ-1089
> URL: https://issues.apache.org/jira/browse/TEZ-1089
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Siddharth Seth
> Assignee: Chen He
> Labels: newbie
> Attachments: TEZ-1089-v2.patch, TEZ-1089.patch
>
>
> CompositeDataMovemntEvent accepts indices for start / end. End happens to be
> a count instead of an index - which can get confusing, especially given the
> name (srcIndexEnd).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
