[ 
https://issues.apache.org/jira/browse/TEZ-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsuyoshi OZAWA updated TEZ-373:
-------------------------------

    Attachment: TEZ-373.11.patch

The polity looks good to me.
* Added DagTypeConverters#convertToTezUserPayload/convertFromTezUserPayload.
* Changed usage policy of {{convertFromTezUserPayload}} and 
{{userPayload.getPayload()}} as follows:
** Calling {{userPayload.getPayload()}} when TezUserPayload field is final.
**  Calling {{userPayload.getPayload()}} with null check when TezUserPayload 
field is NOT final and can be null.
** Using {{convertFromTezUserPayload()}} only before RPC.

> Create UserPayload class
> ------------------------
>
>                 Key: TEZ-373
>                 URL: https://issues.apache.org/jira/browse/TEZ-373
>             Project: Apache Tez
>          Issue Type: Task
>            Reporter: Bikas Saha
>            Assignee: Tsuyoshi OZAWA
>              Labels: newbie
>         Attachments: TEZ-373.1.patch, TEZ-373.10.patch, TEZ-373.11.patch, 
> TEZ-373.2.patch, TEZ-373.3.patch, TEZ-373.4.patch, TEZ-373.5.patch, 
> TEZ-373.6.patch, TEZ-373.7.patch, TEZ-373.8.patch, TEZ-373.9.patch
>
>
> Currently Tez allows user payload to be passed as byte[]. Within Tez code is 
> hard to understand where byte[] is userPayload and where is not user payload. 
> If we create a TezUserPayload class that contains byte[] as a member then its 
> much easier to search and identify in code.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to