[ 
https://issues.apache.org/jira/browse/TEZ-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026154#comment-14026154
 ] 

Bikas Saha commented on TEZ-1193:
---------------------------------

Also, please provide the patch using "git diff --no-prefix" if you are using a 
git repo. Thats more typical. Also please follow the tab/space conventions as 
used in the rest of the code base. We more or less follow hadoop coding 
conventions as described here in case you are interested. 
https://wiki.apache.org/hadoop/CodeReviewChecklist. In short, we are not too 
fussy as long as it looks similar to the rest of the code.

> Make 'tez.lib.uris' dependency optional
> ---------------------------------------
>
>                 Key: TEZ-1193
>                 URL: https://issues.apache.org/jira/browse/TEZ-1193
>             Project: Apache Tez
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>            Priority: Minor
>         Attachments: TEZ-1193.patch
>
>
> Hadoop/YARN provides a mechanism to setup a runtime classpath of Tez/YARN job 
> through LocalResources. Tez exposes setting of LocalResources through 
> AMConfiguration and Vertex thuis allowing AM and ACs have its independent 
> classpath which can include Tez (depending on how Tez job is written). This 
> means that setting _tez.lib.uris_ and installing Tez all together should be 
> optional since its libraries could be easily propagated during job submission.
> It also ensures that the Tez libraries that were used during build are the 
> same that are used during the runtime.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to