[
https://issues.apache.org/jira/browse/TEZ-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026177#comment-14026177
]
Siddharth Seth commented on TEZ-1194:
-------------------------------------
Not really in favour of doing this. I think it'll end up complicating the code
quite a bit - mixing byte arrays and byte buffers and using the wrapper almost
like a Union.
Bytebuffers is something I'm in favour of; IIRC that was how payloads were
initially specified when they were added - far more flexibility compare to byte
arrays. Since several other APIs are also changing in 0.5, moving back to
ByteBuffers before making the next release, while painful, is something we
should consider - and avoid adding changes for backward compatibility which
will be much tougher to remove later.
> Make TezUserPayload user facing for payload specification
> ---------------------------------------------------------
>
> Key: TEZ-1194
> URL: https://issues.apache.org/jira/browse/TEZ-1194
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
>
> Now that we have TezUserPayload being used internally to represent user
> payload it may be useful to make it user facing on the API for specifying
> payloads. Advantages
> 1) Clear code for the user instead of having untyped byte[] everywhere
> 2) Lets us internally evolve the representation of user payload and make it
> more efficient without having to break APIs. We can start with
> TezUserPayload(byte[]) and then move on to TezUserPayload(ByteBuffer) and so
> on while maintaining backwards compatibility without needing to add new
> methods. Old code can be translated within TezUserPayload while user migrates
> the code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
