[
https://issues.apache.org/jira/browse/TEZ-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026806#comment-14026806
]
Hitesh Shah commented on TEZ-1131:
----------------------------------
Some minor comments:
- Dest vs Destination. Inconsistency in function names.
- remove commented out code in Edge.java
Question on addition of sourceOutputIndex for
routeDataMovementEventToDestination(). How is a composite data movement event
that spans multiple output indices to be handled?
Looks fine for the most part.
> Simplify EdgeManager.routeDataMovementEventToDestination()
> ----------------------------------------------------------
>
> Key: TEZ-1131
> URL: https://issues.apache.org/jira/browse/TEZ-1131
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-1131.1.patch
>
>
> 2 pieces of feedback from [~daijy]
> 1) Its not clear the event.sourceIndex needs to be accessed. Solution - Make
> it part of the method parameters
> 2) the Map<InputIndex, List<TaskIndex>> is convoluted. Solution - Replace
> with Map<TaskIndex, InputIndex>. Amazing why we did not do this in the first
> place.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
