[
https://issues.apache.org/jira/browse/TEZ-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siddharth Seth updated TEZ-1169:
--------------------------------
Attachment: TEZ-1169.5.txt
Final patch for commit. Thanks for the reviews.
bq. Unnecessary member variable + createAll method call when the new static
getter() suffices?
Just allows every vertex to share a common instance.
bq. If we are renaming additionalInputs ... , rootInputUpdatedSpecs
Renamed both. We should eventually rename the methods like setAdditionalInputs
and setAdditionalOutputs as well, but not in this patch.
bq. testVertexRootInputSpecUpdateAll and testVertexRootInputSpecUpdatePerTask
They are testing separate functionality, and can fail independently. Leaving as
is for now.
bq. Given that setNumPhysicalInputs will now be specified to 1 for MRInput
Will do this in TEZ-1168; it will likely cause a conflict with the existing
patch there otherwise.
bq. I would again suggest getting ride of the defaults ..
Refactoring AMSplitGenerator and forcing users to set this up needs additional
synchronization, post TEZ-937, assuming we still want to.
> Allow numPhysicalInputs to be specified for RootInputs
> ------------------------------------------------------
>
> Key: TEZ-1169
> URL: https://issues.apache.org/jira/browse/TEZ-1169
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-1169.1.txt, TEZ-1169.2.txt, TEZ-1169.3.txt,
> TEZ-1169.4.txt, TEZ-1169.5.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
