[ 
https://issues.apache.org/jira/browse/TEZ-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027322#comment-14027322
 ] 

Bikas Saha commented on TEZ-1131:
---------------------------------

Thanks for the review! [~daijy] This may be a breaking change for you. Probably 
not. TEZ-1169 is a breaking change for you. It adds an extra parameter 
(RootInputSpec) to setParallelism() API which in your case is simply null.

> Simplify EdgeManager APIs
> -------------------------
>
>                 Key: TEZ-1131
>                 URL: https://issues.apache.org/jira/browse/TEZ-1131
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>             Fix For: 0.5.0
>
>         Attachments: TEZ-1131.1.patch, TEZ-1131.2.patch
>
>
> 2 pieces of feedback from [~daijy] 
> 1) Its not clear the event.sourceIndex needs to be accessed. Solution - Make 
> it part of the method parameters
> 2) the Map<InputIndex, List<TaskIndex>> is convoluted. Solution - Replace 
> with Map<TaskIndex, InputIndex>. Amazing why we did not do this in the first 
> place.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to