[ 
https://issues.apache.org/jira/browse/TEZ-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046505#comment-14046505
 ] 

Bikas Saha edited comment on TEZ-699 at 6/27/14 10:59 PM:
----------------------------------------------------------

Name could be more clear?  "tez.container.max.xmx-fraction"? or 
"tez.container.max.java.heap-fraction"
{code}
+  public static final String TEZ_MEMORY_MAX_HEAP_RATIO =
+      TEZ_PREFIX + "memory.max.heap.ratio";
+  public static final double TEZ_MEMORY_MAX_HEAP_RATIO_DEFAULT = 0.8;{code}

Rest looks good! This is going to solve a really big pain point for users and 
resolve inadvertent misconfigurations.



was (Author: bikassaha):
Name could be more clear?  "tez.container.max.xmx-fraction"? or 
"tez.container.max.java.heap-fraction"
{code}
+  public static final String TEZ_MEMORY_MAX_HEAP_RATIO =
+      TEZ_PREFIX + "memory.max.heap.ratio";
+  public static final double TEZ_MEMORY_MAX_HEAP_RATIO_DEFAULT = 0.8;{code}



> Have sensible defaults for java opts
> ------------------------------------
>
>                 Key: TEZ-699
>                 URL: https://issues.apache.org/jira/browse/TEZ-699
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Hitesh Shah
>         Attachments: TEZ-699.1.patch, TEZ-699.2.patch
>
>
> Its a burden to have to specify them all the time. API's already exist if 
> users want to set special values. Also, for vertex memory would be good to 
> have a TezUtils.getDefaultVertexResource() with a sensible resource size.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to