[
https://issues.apache.org/jira/browse/TEZ-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072948#comment-14072948
]
Siddharth Seth commented on TEZ-1304:
-------------------------------------
Couple more comments post the review on TEZ-717 earlier.
- FrameworkClient should not be throwing YarnExceptions - that should be
handled within the Yarn implementation of the client. Lets get the patch in,
and fix this in a follow up jira.
- additionalLocalResources.clear - this is managed by TezClient so I think
cleaning it up also belongs in the TezClient (instead of pushing it to
individual implementations)
- It's possible that an error occurs after an applicationId is created, but
before the App is actually submitted to YARN. In such a case, most of the
methods will work incorrectly - since the TezYarnClient has the incorrect (new
appId). Updating this only on a successful submitApplication invocation should
fix this. Longer term, I think it makes sense to pass in the ApplicationId -
but not in this jira.
- Minor: In FrameworkClient - amConfig and isSession can be final
> Create execution underlying framework abstraction layer
> -------------------------------------------------------
>
> Key: TEZ-1304
> URL: https://issues.apache.org/jira/browse/TEZ-1304
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: TEZ-1304-v1.patch
>
>
> Continuing in the direction of hiding the internals of the execution
> framework, this patch aims at abstracting it away from the tez client
> implementation. This will further ease the addition of other execution
> frameworks such as Tez Local Mode.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
