[ 
https://issues.apache.org/jira/browse/TILES-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998898#comment-12998898
 ] 

Xiaoming Shi commented on TILES-521:
------------------------------------

Hi Antonio,

Since JspExpressionFactoryFactory itself is a Factory, the best method may be 
caching the value of JspExpressionFactory where it is used. But it may affect 
many codes.

The other method is to add a field in the class JspExpressionFactoryFactory 
which can be used to store the return value of JspFactory.getDefaultFactory(). 
If a JspExpressionFactory object is only used for once, then this method may 
not improve any performance. 



> JspFactory.getDefaultFactory() is synchronized, We can cache the return value 
> to improve performance
> ----------------------------------------------------------------------------------------------------
>
>                 Key: TILES-521
>                 URL: https://issues.apache.org/jira/browse/TILES-521
>             Project: Tiles
>          Issue Type: Bug
>          Components: tiles-el
>    Affects Versions: 2.2.2
>            Reporter: Xiaoming Shi
>
> In the file
> tiles-2.2.2/src/tiles-el/src/main/java/org/apache/tiles/el/JspExpressionFactoryFactory.java
>       line:61
> The value returned by JspFactory.getDefaultFactory() can be cached to reduce 
> race and improve performance 
> (Similar to the Apache Bug, 
> https://issues.apache.org/bugzilla/show_bug.cgi?id=44408)

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to