potiuk commented on issue #24:
URL: https://github.com/apache/tooling-agents/issues/24#issuecomment-4681831003
Thanks @andrewmusselman — triage of the L3/opus-4.8 task-sdk `b82b881` scan
(7 findings) against current `main`. Net: **nothing actionable as a security
fix.** The Task SDK runs in the per-task worker process where the actor is the
trusted DAG author and the worker↔scheduler channel is internal, so none of
these cross a trust boundary.
| # | Finding | Disposition |
|---|---|---|
| F-001 / F-002 | `_BinaryDigestCache` / coordinator-cache concurrency
(CWE-362) | **Not reachable as described** — the supervisor runs each task in a
forked *subprocess* (one short-lived supervisor per task), the coordinator
module has no threading, and the executable-bundle coordinator isn't driven
from multiple in-process threads. No concurrent access to the process-wide
cache, so the race premise doesn't hold. |
| F-004 | Terminal-state IPC send failure → SKIPPED / UP_FOR_RESCHEDULE /
DEFERRED can be recorded as SUCCESS | **Known & intentional** — the code
already documents the tradeoff (fail-closed for FAILED / UP_FOR_RETRY; *not*
for the other three, because exiting non-zero would map them to FAILED, which
is strictly worse) and points at the real fix location
(`supervisor.final_state`). IPC-failure-triggered, not attacker-driven — a
core-reliability item, not security. |
| F-003 | Blocked-DB-access control doesn't log the bypass attempt | By
design — the control fails closed; the actor is the trusted DAG author;
observability only. |
| F-005 | Execution API client lacks explicit httpx pool limits in all
construction paths | No exploit path — the production supervisor path already
bounds connections; only test / in-process paths fall back to httpx defaults,
which are sane. L3 documentation-alignment. |
| F-006 | Execution API client relies on httpx's implicit
`follow_redirects=False` default | Safe today; an explicit
`kwargs.setdefault("follow_redirects", False)` would be a reasonable
footgun-guard on the JWT-bearing client, but it's defense-in-depth on an
internal channel — not actioned this round. |
| F-007 (info) | Remote-logging connection cached with no TTL | The per-task
short-lived supervisor bounds the window to a single task run; not exploitable.
|
No CVEs or PRs from this round.
---
This response was generated by AI and reviewed by @potiuk before posting; a
human maintainer will follow up on anything worth a closer look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
