singlaamitesh opened a new pull request, #1432:
URL: https://github.com/apache/tooling-trusted-releases/pull/1432
Fixes #1368
## Pull request summary <!-- markdownlint-disable-line MD041 -->
**Meaningful subject (required):**
<!--
Provide a clear, concise subject line.
Good:
"Fix schema endpoint auth bypass for OpenAPI"
"Refactor report authorization filters"
Bad:
"Fix"
"Updates"
-->
**Description:**
<!-- Explain what this PR changes and why -->
---
## Required acknowledgements
Please replace each `[ ]` with `[x]` to confirm.
PRs missing confirmations may be closed or converted to Draft.
* [ ] I have read and followed **CONTRIBUTING.md**
* [ ] I have read **DEVELOPMENT.md**
* [ ] I have run the required tests and checks locally
* [ ] All required checks are currently passing
* [ ] This branch is **rebased on the current `main` branch**
---
## Draft requirement
If **any** of the following are true:
* Tests or checks are failing
* Work is incomplete
* Rebase on `main` is pending
**This PR MUST be opened or converted to a Draft**:
Convert to a ready PR only after all acknowledgements above can be confirmed.
---
## Rebase confirmation details (optional but encouraged)
<!--
If helpful, note how the rebase was done:
git fetch origin
git rebase origin/main
-->
---
## Additional notes
<!--
Anything reviewers should know:
- Design decisions
- Follow-up work
- Compatibility concerns
-->
---
In ReleaseManager.record() (atr/storage/writers/distributions.py), the
pending->confirmed branch (existing.pending and not pending) only flipped
existing.pending to False without persisting the newly-resolved
staging/upload_date/api_url/web_url, so record_from_data's confirmed metadata
was silently dropped; now those fields are assigned before commit, mirroring
__upgrade_staging_to_final. Added a regression test in
tests/unit/test_release_manager_writer_surface.py that reproduces the bug
(failed before the fix, passes after).
**How this was tested:** `make your changes** following our [code
conventions](https://release-test.apache.org/docs/code-conventions)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
