rob05c commented on a change in pull request #2288: Fix TO old Perl GUI 
CRConfig diff
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2288#discussion_r189039183
 
 

 ##########
 File path: traffic_ops/app/lib/UI/Topology.pm
 ##########
 @@ -848,6 +848,9 @@ sub stringify_cs_ds {
     foreach my $ds ( sort keys %{$csds} ) {
         if ( ref( $csds->{$ds} ) eq 'ARRAY' ) {
             foreach my $map ( @{ $csds->{$ds} } ) {
+                if ( ! defined($map) ) {
 
 Review comment:
   This changes the diff text to ignore `undef` in the hash from the JSON 
array. For reasons I can't figure out, Perl deserializes these JSON keys from 
HTTP with extra undefs in the hash, but not when loading from the database. 
   
   Both were generated by the same Go function, and as far as I can tell the 
text is identical. There are no nulls or anything else in the JSON array text, 
whitespace is the same. I have no idea why one Perl hash ends up with undefs 
when decoding, and the other doesn't. But this fixes the diff to ignore them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to