rob05c commented on a change in pull request #2360: Ds adjustments
URL:
https://github.com/apache/incubator-trafficcontrol/pull/2360#discussion_r192412566
##########
File path:
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv12.go
##########
@@ -330,6 +330,10 @@ func CreateV12(db *sqlx.DB, cfg config.Config)
http.HandlerFunc {
return
}
+ if ds.RoutingName == nil || *ds.RoutingName == "" {
+ ds.RoutingName = utils.StrPtr("cdn")
Review comment:
This kind of sanitization is usually done in the `Sanitize` funcs. This
would be better in `sanitiveV12`, so we don't forget to do it in CreateV14 and
future versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services