rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for
backup edge cachegroup
URL:
https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r193758109
##########
File path: traffic_ops/traffic_ops_golang/crconfig/edgelocations.go
##########
@@ -32,7 +32,7 @@ func makeLocations(cdn string, db *sql.DB)
(map[string]tc.CRConfigLatitudeLongit
// TODO test whether it's faster to do a single query, joining lat/lon
into servers
q := `
-select cg.name, t.name as type, cg.latitude, cg.longitude from cachegroup as cg
+select cg.name, cg.id, t.name as type, cg.latitude, cg.longitude from
cachegroup as cg
Review comment:
I think the string boolean thing might have stemmed from Perl not having
real booleans. Now that it's been migrated to Go, we _could_ use real booleans
in the JSON. But since there are a bunch of string bools in the CRConfig
already, I guess it's better to be consistent and keep it as a string bool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
