rawlinp commented on a change in pull request #2314: Remove
deliveryservice.org_server_fqdn column/compute it from Origin table
URL: https://github.com/apache/trafficcontrol/pull/2314#discussion_r195185045
##########
File path:
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv13.go
##########
@@ -306,6 +312,88 @@ func createDefaultRegex(tx *sql.Tx, dsID int, xmlID
string) error {
return nil
}
+func parseOrgServerFQDN(orgServerFQDN string) (*string, *string, *string,
error) {
Review comment:
It could, but I'd still have to parse the port out of `URL.Host` and make
sure `URL.Scheme` is either http or https, and run through the rest of the URL
struct to make sure things like Path, queryParams, and UserInfo don't exist.
IMO doing it w/ the regex makes more sense since we're only interested in
scheme, fqdn, and port.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
