rob05c commented on a change in pull request #2451: Fix delivery service
validation
URL: https://github.com/apache/trafficcontrol/pull/2451#discussion_r197287475
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -241,15 +241,20 @@ func (ds *DeliveryServiceNullableV12) Sanitize() {
}
}
-func getTypeName(tx *sql.Tx, id int) (string, bool, error) {
+func getTypeData(tx *sql.Tx, id int) (string, string, bool, error) {
Review comment:
Mind adding a Godoc function comment here, explaining the return params?
That way someone doesn't have to read the function to figure out what each
string being returned is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
