mitchell852 commented on a change in pull request #2307: Add TO Go cdns/routing
URL: https://github.com/apache/trafficcontrol/pull/2307#discussion_r199622126
##########
File path: traffic_ops/traffic_ops_golang/routes.go
##########
@@ -104,7 +104,7 @@ func Routes(d ServerData) ([]Route, []RawRoute,
http.Handler, error) {
{1.1, http.MethodGet, `cdns/configs$`,
handlerToFunc(proxyHandler), 0, NoAuth, []Middleware{}},
{1.1, http.MethodGet, `cdns/domains$`,
handlerToFunc(proxyHandler), 0, NoAuth, []Middleware{}},
{1.1, http.MethodGet, `cdns/health$`,
handlerToFunc(proxyHandler), 0, NoAuth, []Middleware{}},
- {1.1, http.MethodGet, `cdns/routing$`,
handlerToFunc(proxyHandler), 0, NoAuth, []Middleware{}},
Review comment:
yes, because TO_golang has no concept of to_extensions (at the moment),
merging this PR would kill the perl to_extension that is currently being used
by Comcast in production.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
