mitchell852 commented on a change in pull request #2591: Manage static dns
entries front-end changes [WIP]
URL: https://github.com/apache/trafficcontrol/pull/2591#discussion_r205508840
##########
File path:
traffic_portal/app/src/common/modules/table/deliveryServiceStaticDnsEntries/TableDeliveryServiceStaticDnsEntriesController.js
##########
@@ -27,6 +27,10 @@ var TableDeliveryServiceStaticDnsEntriesController =
function(deliveryService, s
$state.reload(); // reloads all the resolves for the view
};
+ $scope.editStaticDnsEntry = function(dsId, staticDnsEntryId) {
+ locationUtils.navigateToPath('/delivery-services/' + dsId +
'/static-dns-entry/' + staticDnsEntryId);
Review comment:
you should make this plural to conform with the rest of TP's routes. so like
this
+ locationUtils.navigateToPath('/delivery-services/' + dsId +
'/static-dns-entries/' + staticDnsEntryId);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
