ezelkow1 commented on a change in pull request #2590: Add s? to cachkey capture
prefix so it will capture both http and https in to http keys
URL: https://github.com/apache/trafficcontrol/pull/2590#discussion_r205530384
##########
File path: traffic_ops/app/lib/UI/DeliveryService.pm
##########
@@ -1432,7 +1432,7 @@ sub get_qstring_ignore_remap {
my $ats_major_version = shift;
if ($ats_major_version >= 6) {
- return " \@plugin=cachekey.so \@pparam=--separator=
\@pparam=--remove-all-params=true \@pparam=--remove-path=true
\@pparam=--capture-prefix-uri=/http:\\/\\/([^?]*)/http:\\/\\/\$1/";
+ return " \@plugin=cachekey.so \@pparam=--separator=
\@pparam=--remove-all-params=true \@pparam=--remove-path=true
\@pparam=--capture-prefix-uri=/https?:\\/\\/([^?]*)/http:\\/\\/\$1/";
Review comment:
Yes looks like that one might work, however ATS is doing something funky
with https. For http the URI its using is just fine, however on an https you
end up with something like:
< X-Cache-Key: localhost:443/
Its stripping the https and bringing in the port
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
