dangogh closed pull request #2594: fixes error with longDesc required error
message
URL: https://github.com/apache/trafficcontrol/pull/2594
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
index f01b9d774..f6e2e808b 100644
---
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
+++
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
@@ -181,7 +181,7 @@
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
<textarea name="longDesc" type="text" class="form-control"
ng-model="deliveryService.longDesc" rows="3" required autofocus></textarea>
- <small class="input-error"
ng-show="hasPropertyError(deliveryService.longDesc,
'required')">Required</small>
+ <small class="input-error"
ng-show="hasPropertyError(deliveryServiceForm.longDesc,
'required')">Required</small>
<small class="input-diff" ng-show="settings.isRequest &&
open() && deliveryService.longDesc != dsCurrent.longDesc">Current Value: [
{{dsCurrent.longDesc}} ]</small>
<span ng-show="hasError(deliveryServiceForm.longDesc)"
class="form-control-feedback"><i class="fa fa-times"></i></span>
</div>
diff --git
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
index 925be25fc..8223bdb67 100644
---
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
+++
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
@@ -181,7 +181,7 @@
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
<textarea name="longDesc" type="text" class="form-control"
ng-model="deliveryService.longDesc" rows="3" required autofocus></textarea>
- <small class="input-error"
ng-show="hasPropertyError(deliveryService.longDesc,
'required')">Required</small>
+ <small class="input-error"
ng-show="hasPropertyError(deliveryServiceForm.longDesc,
'required')">Required</small>
<small class="input-diff" ng-show="settings.isRequest &&
open() && deliveryService.longDesc != dsCurrent.longDesc">Current Value: [
{{dsCurrent.longDesc}} ]</small>
<span ng-show="hasError(deliveryServiceForm.longDesc)"
class="form-control-feedback"><i class="fa fa-times"></i></span>
</div>
diff --git
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.Steering.tpl.html
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.Steering.tpl.html
index e0ca22f12..e353bf948 100644
---
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.Steering.tpl.html
+++
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.Steering.tpl.html
@@ -164,7 +164,7 @@
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
<textarea name="longDesc" type="text" class="form-control"
ng-model="deliveryService.longDesc" rows="3" required autofocus></textarea>
- <small class="input-error"
ng-show="hasPropertyError(deliveryService.longDesc,
'required')">Required</small>
+ <small class="input-error"
ng-show="hasPropertyError(deliveryServiceForm.longDesc,
'required')">Required</small>
<small class="input-diff" ng-show="settings.isRequest &&
open() && deliveryService.longDesc != dsCurrent.longDesc">Current Value: [
{{dsCurrent.longDesc}} ]</small>
<span ng-show="hasError(deliveryServiceForm.longDesc)"
class="form-control-feedback"><i class="fa fa-times"></i></span>
</div>
diff --git
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.anyMap.tpl.html
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.anyMap.tpl.html
index 4170dc300..d3a4c5c00 100644
---
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.anyMap.tpl.html
+++
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.anyMap.tpl.html
@@ -149,7 +149,7 @@
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
<textarea name="longDesc" type="text" class="form-control"
ng-model="deliveryService.longDesc" rows="3" required autofocus></textarea>
- <small class="input-error"
ng-show="hasPropertyError(deliveryService.longDesc,
'required')">Required</small>
+ <small class="input-error"
ng-show="hasPropertyError(deliveryServiceForm.longDesc,
'required')">Required</small>
<small class="input-diff" ng-show="settings.isRequest &&
open() && deliveryService.longDesc != dsCurrent.longDesc">Current Value: [
{{dsCurrent.longDesc}} ]</small>
<span ng-show="hasError(deliveryServiceForm.longDesc)"
class="form-control-feedback"><i class="fa fa-times"></i></span>
</div>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
